Document an additional behavior of erb-right-trim#717
Closed
maxjacobson wants to merge 1 commit intomarcoroth:mainfrom
Closed
Document an additional behavior of erb-right-trim#717maxjacobson wants to merge 1 commit intomarcoroth:mainfrom
maxjacobson wants to merge 1 commit intomarcoroth:mainfrom
Conversation
erb-right-trim flagged a number of instances where we're using `-%>` when we should be using `%>`. In fixing them, I'd like to be able to link my team to the herb docs where they can read more about the change, but the page doesn't currently mention this behavior of this linter. Seems worth mentioning.
Author
|
I tried to put together a playground link showing the issues that I'm seeing locally, but surprisingly this is not flagged on the web 🤔 But locally we are seeing things like this: Hm 🤔 |
Owner
|
Hey @maxjacobson, sorry for the confusion. The version you are running is v0.7.5, the playground is running on The rule in v0.7.5 incorrectly flagged cases where |
Author
|
ah! whoops. sounds like this one can safely be closed then right? |
Owner
|
Yes, I think so. Sorry for the confusion. I hope I get to wrap up this big v0.8.0 release soon-ish here. |
Author
|
No worries, and no rush 🙂 |
maxjacobson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
erb-right-trim flagged a number of instances where we're using
-%>when we should be using%>. In fixing them, I'd like to be able to link my team to the herb docs where they can read more about the change, but the page doesn't currently mention this behavior of this linter. Seems worth mentioning.Incidentally, this is the tweak I wanted to make when I noticed #716 🙂